Add Hard Delete Action to SafeDeleteAdmin #236
Conversation
|
Thanks for the PR 👍 . Could you check and fix the flake8 errors. With only two functions, this should be all right to duplicate the logic there. |
|
Fixed the Flake8 errors |
|
Thanks, there's still one left: |
Xalph555
force-pushed
the
Hard-Delete-Admin-Action
branch
from
28a0a93
to
47c349a
Compare
|
Sorry about that. Hopefully I got them all now. |
|
Added commit in attempt to fix the latest workflow errors |
|
Thanks again for the PR and the follow ups 👌 . |
|
I see that in the CHANGES file this one is mentioned for release 1.3.3, but as stated is not available as pip package yet. Is there any ETA on when this feature will be released? This is a feature that we would really like to implement in some of our projects. |
|
Hi @jvdminne , I just released 1.3.3, enjoy 😃 . |
|
Awesome, thanks! I will try it asap. |
Adding a hard delete action to allow admins to permanently delete soft deleted records.
Function itself is near identical to the
undelete_selectedaction but I am unsure whether we want to create another function, or functions, to extract the common behaviours.